Fix incorrect doctest references in fibonacci functions#14200
Open
Shivanggaryaa wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
Fix incorrect doctest references in fibonacci functions#14200Shivanggaryaa wants to merge 2 commits intoTheAlgorithms:masterfrom
Shivanggaryaa wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
algorithms-keeper
bot
added
enhancement
poyea
force-pushed
the
docs-first-contribution
branch
from
87eaeb4 to
1dfd884
Compare
poyea
approved these changes
Jan 25, 2026
algorithms-keeper
bot
removed
the
awaiting reviews
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect doctest references in maths/fibonacci.py so the doctest examples invoke the function being documented.
Changes:
- Updated
fib_recursive,fib_recursive_cached, andfib_memoizationdoctest calls to reference themselves (instead offib_iterative). - Aligned the
fib_recursive_term(-1)doctest to expectValueError(matching the implementation).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
119
to
123
| >>> fib_recursive_term(-1) | ||
| Traceback (most recent call last): | ||
| ... | ||
| Exception: n is negative | ||
| ValueError: n is negative | ||
| """ |
There was a problem hiding this comment.
The doctest examples in this inner fib_recursive_term docstring won’t be collected by pytest’s --doctest-modules because fib_recursive_term is defined inside fib_recursive and is not a module-level object. If you want these examples to run in CI, move them into fib_recursive’s docstring or promote fib_recursive_term to a module-level helper.
poyea
force-pushed
the
docs-first-contribution
branch
from
1dfd884 to
3b9305c
Compare
poyea
approved these changes
Jan 25, 2026
algorithms-keeper
bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Several Fibonacci functions had doctests referencing
fib_iterativeinstead of the function being documented.
This PR fixes doctest references for:
No functional changes were made.
Checklist: